-
Notifications
You must be signed in to change notification settings - Fork 3k
Redo #4856 Platform descriptor should only be downloaded when targeting a different version #4885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo #4856 Platform descriptor should only be downloaded when targeting a different version #4885
Conversation
redo of #4856 |
c982bab
to
e197092
Compare
Not sure why this says 109 files are changed and #4856 says 108 ... there are the same amount of files changed according to |
this fails consistently for me locally:
|
if you want to do the minimal build that fails consistently use this mvn cmd:
That one always fails for me on this branch/PR. both current and old. |
…scriptor loader to load the default version from the classpath
e197092
to
4ec22be
Compare
FWIW, I built it locally and run the tests like you mention and didn't see any failures. |
@aloubyansky ack'ed and builds locally for me as long as not running 3 lsp-java at the same time so merging. |
Since I had to git revert the merge to get master to build I could not just rebase.
Did a git diff and applied it to master instead. There was no merge errors/conflicts.