Platform descriptor should only be downloaded when targeting a different version #4856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aloubyansky
force-pushed
the
local-platform-descriptor
branch
from
f53410d to
2af1104
Compare
aloubyansky
added
the
area/platform
|
just noticed the title "Platform descriptor should only be downloaded when targeting a different version" ...what does that mean ? |
|
Meaning it should perform resolution only when the version of the plugin is different than the Quarkus version. |
|
resolution of what exactly ? |
|
i.e. if I have two platforms with same quarkus version I would still expect a different result... |
|
Sure. Non quarkus-bom platforms will be resolved from Maven. |
aloubyansky
force-pushed
the
local-platform-descriptor
branch
2 times, most recently
from
4ce6616 to
c85bc31
Compare
…scriptor loader to load the default version from the classpath
aloubyansky
force-pushed
the
local-platform-descriptor
branch
from
c85bc31 to
faf707f
Compare
maxandersen
approved these changes
Oct 25, 2019
|
had to revert this as it caused master to fail in quarkus-test-extension-deployment :/ |
maxandersen
added a commit
that referenced
this pull request
Oct 26, 2019
…ptor Redo #4856 Platform descriptor should only be downloaded when targeting a different version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4822
Removed the legacy extensions.json and enahanced the platform json descriptor loader to load the default version from the classpath