Skip to content

Properly set typeOfHandler field of RouteBuildItem #48567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2025
Merged

Properly set typeOfHandler field of RouteBuildItem #48567

merged 2 commits into from
Jun 24, 2025

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jun 24, 2025 •
edited
Loading

@quarkus-bot quarkus-bot

This comment was marked as resolved.

Sign in to view
@geoand geoand requested a review from gastaldi June 24, 2025 08:52
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jun 24, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 93319a7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

gastaldi
gastaldi approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...x-http/deployment-spi/src/main/java/io/quarkus/vertx/http/deployment/spi/RouteBuildItem.java
private final String routeConfigKey;

@SuppressWarnings("OptionalUsedAsFieldOrParameterType")
@Deprecated(since = "3.25", forRemoval = true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add a javadoc here too suggesting what to use instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any uses of it, I only deprecated it now so we can remove it later. The only use of the Build Item I see uses the builder.

@geoand geoand merged commit 6d40679 into quarkusio:main Jun 24, 2025
110 of 111 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jun 24, 2025
@geoand geoand deleted the #48215 branch June 24, 2025 12:41
@gsmet gsmet modified the milestones: 3.25 - main, 3.24.1 Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees

No one assigned

Labels

area/vertx kind/bugfix triage/flaky-test

Projects

None yet

Milestone

3.24.1

Development

Successfully merging this pull request may close these issues.

Bug in RouteBuildItem the builder has asBlockingRoute but not used internally

3 participants

@geoand @gastaldi @gsmet