Skip to content

Conversation

holly-cummins
Copy link
Contributor

@holly-cummins holly-cummins commented Jun 23, 2025

I've added more test coverage for Kafka dev services. Three of the tests don't pass, but should pass once #47627 is implemented. In the meantime I've @Disabled them.

I also moved a port checking utility into a common location.

@ozangunalp and @cescoffier, do we have tests for the Kafka container re-use and shared networking and so on? I couldn't spot them, but I didn't really know what I was looking for. I assumed they were there, so I didn't add any, but it seems like an area at risk of regression when implementing #47627, so we will want the protection of tests.

Copy link

quarkus-bot bot commented Jun 24, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 43a064a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/micrometer-opentelemetry/deployment

io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod - History

  • Stream has no elements - java.lang.IllegalArgumentException
java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lambda$lastReading$2(MetricDataFilter.java:213)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReading(MetricDataFilter.java:213)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:231)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod(MicrometerTimedInterceptorTest.java:77)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:521)

@cescoffier cescoffier moved this to In Progress in WG - Dev Services Lifecycle Jun 25, 2025
@holly-cummins holly-cummins merged commit 3289f66 into quarkusio:main Jun 25, 2025
42 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in WG - Dev Services Lifecycle Jun 25, 2025
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants