Add more kafka dev service tests #48555
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added more test coverage for Kafka dev services. Three of the tests don't pass, but should pass once #47627 is implemented. In the meantime I've
@Disable
d them.I also moved a port checking utility into a common location.
@ozangunalp and @cescoffier, do we have tests for the Kafka container re-use and shared networking and so on? I couldn't spot them, but I didn't really know what I was looking for. I assumed they were there, so I didn't add any, but it seems like an area at risk of regression when implementing #47627, so we will want the protection of tests.