-
Notifications
You must be signed in to change notification settings - Fork 3k
Keep the codestart Gradle wrapper in sync with version configured #48506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a follow-up of quarkusio#48395 and it should be more future-proof and also easier to backport.
Status for workflow
|
@reaver585 just fyi, this is a follow up to your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ia3andy please review this one, thanks!
Merged after discussion with @aloubyansky |
Thank you, this closes the discussion I opened recently: #48439 |
Follow-up of quarkusio#46525 and also related to quarkusio#48506 We need the Maven wrapper to be present in some modules to avoid having the nested Maven runs inherit from the root .mvn/maven.config. But it's better to copy it in the build when needed. Per gripe from @aloubyansky.
This is a follow-up of #48395 and it should be more future-proof and also easier to backport.
@ia3andy I have a question for you: in
devtools/project-core-extension-codestarts
, we also include a Gradle wrapper in thegradle-wrapper/
directory of the jar. Do you know if this is actually used or if we should drop this? I see commits in there from time to time to fix things but I don't understand why we would have two copies of the wrapper. Or is it to support older projects?