Skip to content

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jun 20, 2025

This is a follow-up of #48395 and it should be more future-proof and also easier to backport.

@ia3andy I have a question for you: in devtools/project-core-extension-codestarts, we also include a Gradle wrapper in the gradle-wrapper/ directory of the jar. Do you know if this is actually used or if we should drop this? I see commits in there from time to time to fix things but I don't understand why we would have two copies of the wrapper. Or is it to support older projects?

This is a follow-up of quarkusio#48395 and it should be more future-proof and
also easier to backport.
@gsmet gsmet requested review from aloubyansky and ia3andy June 20, 2025 16:32
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 20, 2025
Copy link

quarkus-bot bot commented Jun 20, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit d707756.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
  ["-3", "-4", "-5", "-6"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.LoggingResourceTest.testException - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.it.opentelemetry.LoggingResourceTest.testException(LoggingResourceTest.java:113)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

@aloubyansky
Copy link
Member

@reaver585 just fyi, this is a follow up to your PR

Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ia3andy please review this one, thanks!

@gsmet gsmet merged commit e401294 into quarkusio:main Jun 24, 2025
57 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jun 24, 2025
@gsmet
Copy link
Member Author

gsmet commented Jun 24, 2025

Merged after discussion with @aloubyansky

@reaver585
Copy link
Contributor

Thank you, this closes the discussion I opened recently: #48439

@gsmet gsmet modified the milestones: 3.25 - main, 3.24.1 Jun 24, 2025
gsmet added a commit to gsmet/quarkus that referenced this pull request Jul 2, 2025
Follow-up of quarkusio#46525
and also related to quarkusio#48506

We need the Maven wrapper to be present in some modules to avoid having
the nested Maven runs inherit from the root .mvn/maven.config.
But it's better to copy it in the build when needed.

Per gripe from @aloubyansky.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants