Skip to content

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Feb 27, 2025

To workaround command line size limit on Windows, we have to use .mvn/maven.config which is sometimes propagated to our tests.

These changes isolate some of our tests from the root .mvn/maven.config.

The whole idea is to have a Maven wrapper in the test directory to avoid bubbling up to the root.

In Maven 4, we should be able to use this new feature just introduced by @cstamas to avoid the problem, but for now that's how it is.

This will hopefully fix the remaining CI issues (until more are discovered...).

@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus area/maven area/testing labels Feb 27, 2025
@gsmet
Copy link
Member Author

gsmet commented Feb 27, 2025

My, I did a gazillion of tests locally and it's still going weird :/.

Pushed another shot at it...

Copy link

quarkus-bot bot commented Feb 27, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit d570b33.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@holly-cummins
Copy link
Contributor

I'm so happy to see this PR, because I've been driving myself mad trying to figure out how main could be green when all the Extension Mojo tests were failing in my branch after a rebase. I still don't understand that, but hopefully I can leave it to @gsmet to care about the 'why', and just rebase again. ❤️

@holly-cummins
Copy link
Contributor

I wonder if it would be more robust to copy the maven wrapper at some point so we don't have two copies of it to maintain? But that could be a future enhancement.

These changes look sensible, but I also wonder if @aloubyansky might have opinions, since he always points out I've misunderstood resource filtering and am doing it wrong.

@gsmet gsmet merged commit 0e7a670 into quarkusio:main Feb 27, 2025
57 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Feb 27, 2025
Copy link
Contributor

@holly-cummins holly-cummins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will also cherry-pick this commit to my branch and report back.

gsmet added a commit to gsmet/quarkus that referenced this pull request Jul 2, 2025
Follow-up of quarkusio#46525
and also related to quarkusio#48506

We need the Maven wrapper to be present in some modules to avoid having
the nested Maven runs inherit from the root .mvn/maven.config.
But it's better to copy it in the build when needed.

Per gripe from @aloubyansky.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus area/maven area/testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants