Correct duplicated context creation in SmallRye Health

[xstefank]

Fixes #47481

[gsmet]

Rebased to get CI fixes.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit a6a9a6c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/opentelemetry

✖ io.quarkus.it.opentelemetry.LoggingResourceTest.testException - History

• Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.it.opentelemetry.LoggingResourceTest.testException(LoggingResourceTest.java:113)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

[HerrDerb]

As I understand it, this commit might break the vertx context propagation for health checks.

We have a Vert.x request filter that sets a local value (request header value) on the Vert.x context of the incoming request. Before this change, the duplicated context used to execute the health check was based on the same context that passed through the Vert.x request filter chain.

With this change, a new duplicated context is created before the Vert.x request filter chain is executed. As a result, any modifications made to the context within a Vert.x request filter will not be visible in the health check, since the health check now runs in a context that was duplicated "too early." I am not able anymore to access the put local from the request filter.

Does this sound alright?

Before change

Incoming Request
      |
      v
[Vert.x Request Filter] --(sets local on context)-->
      |
      v
[Duplicate Context for Health Check]
      |
      v
[Health Check Execution]

After change

Incoming Request
      |
      v
      +------------  [Duplicate Context for Health Check during build build up]  <--- context duplicated too early
      |                             |
      |                             |
      v                             v
[Vert.x Request Filter]      [Health Check Execution]
  (sets local on context)      (does NOT see local set by filter)

[gsmet]

@HerrDerb can you create an issue with the details and a link to this PR? It will be easier to track.

Thanks!