Vertx context propagation broken in smallrye health since 3.23.0

[HerrDerb]

We have a Vert.x request filter that sets a local value (request header value) on the Vert.x context of the incoming request. Before this change, the duplicated context used to execute the health check was based on the same context that passed through the Vert.x request filter chain.

Recently Correct duplicated context creation in SmallRye Health got merged and might have broken this behaviour.

With this change, a new duplicated context is created before the Vert.x request filter chain is executed. As a result, any modifications made to the context within a Vert.x request filter will not be visible in the health check, since the health check now runs in a context that was duplicated "too early." I am not able anymore to access the put local from the request filter.

Before change

Incoming Request
      |
      v
[Vert.x Request Filter] --(sets local on context)-->
      |
      v
[Duplicate Context for Health Check]
      |
      v
[Health Check Execution]

After change

Incoming Request
      |
      v
      +------------  [Duplicate Context for Health Check during build build up]  <--- context duplicated too early
      |                             |
      |                             |
      v                             v
[Vert.x Request Filter]      [Health Check Execution]
  (sets local on context)      (does NOT see local set by filter)

Reproducer

https://github.com/HerrDerb/quarkus-issue/tree/health-vertx-issue
Test fails with current quarkus version.
Test succeed with 3.23.0

Originally posted by @HerrDerb in #48057 (comment)

[quarkus-bot]

/cc @FroMage (context-propagation), @Ladicek (smallrye), @jmartisk (health,smallrye), @manovotn (context-propagation), @phillip-kruger (smallrye), @radcortez (smallrye), @xstefank (health)

[cescoffier]

Yes, we isolated the duplicated context for the health checks. What you need, if I understand correctly, is not to have an isolated context.

[HerrDerb]

@cescoffier Kind of, an isolated context on health check level certainly is desired, but now they are also isolated from its origin, the request.
Why exactly weren't they isolated before? It seems that each health check was run on a new duplicate context already.

[xstefank]

@HerrDerb yes, but it was still not enough for the Verx MDC logger isolation - #47481 as it expects a separate context. But I understand your issue. TBH, I don't know if we can keep both behaviors at the same time. I need to take a look again. I'm more inclined to change the the VertxMDC logging.

[HerrDerb]

I was looking into it a bit. What bothers me is that the vertx context gets "destroyed" to solve a thread based problem.

By fixing this in smallrye health directly, it seems to solve the problem from @atanasnik and would keep the vertx context intact

This pr should make recent change in the quarkus extension obsolete-> smallrye/smallrye-health#642

Double check is certainly needed :)

[HerrDerb]

@xstefank This seems to fix both: #48722
I did a quarkus build and successfully tested it on @atanasnik reproducer. The same quarkus build lets my test pass as well.

[xstefank]

Just a note that this is not caused by #48057. Same behavior with this reverted.