Skip to content

Disable Dev Services fully in oidc-wiremock-logout IT #47511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged

Disable Dev Services fully in oidc-wiremock-logout IT #47511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
451b881
Disable Dev Services fully in oidc-wiremock-logout IT
gsmet Apr 23, 2025
e13e5e8
Always test Docker availability last
gsmet Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .../keycloak/src/main/java/io/quarkus/devservices/keycloak/KeycloakDevServicesProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,8 @@ DevServicesResultBuildItem startKeycloakContainer(
}

if (devSvcRequiredMarkerItems.isEmpty()
|| linuxContainersNotAvailable(dockerStatusBuildItem, devSvcRequiredMarkerItems)
|| oidcDevServicesEnabled()) {
|| oidcDevServicesEnabled()
|| linuxContainersNotAvailable(dockerStatusBuildItem, devSvcRequiredMarkerItems)) {
if (devService != null) {
closeDevService();
}
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/oidc-wiremock-logout/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
quarkus.keycloak.devservices.enabled=false
quarkus.devservices.enabled=false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That appears to disable it completely for all platforms

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, looks like they are indeed not required for this test - though a more general fix in the linked seems to work better in a sense where we want to check if a lightweight OIDC service should be used, so that PR is needed anyway.


quarkus.oidc.code-flow-form-post.auth-server-url=${keycloak.url}/realms/quarkus-form-post/
quarkus.oidc.code-flow-form-post.client-id=quarkus-web-app
Expand Down
Loading