Disable Dev Services fully in oidc-wiremock-logout IT #47511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are not required and it's failing on Windows as Docker is not available.
quarkus-bot
bot
added
area/devservices
area/oidc
env/windows
Status for workflow
|
sberyozkin
reviewed
Apr 23, 2025
| @@ -1,4 +1,4 @@ | |||
| quarkus.keycloak.devservices.enabled=false | |||
| quarkus.devservices.enabled=false | |||
There was a problem hiding this comment.
That appears to disable it completely for all platforms
There was a problem hiding this comment.
Never mind, looks like they are indeed not required for this test - though a more general fix in the linked seems to work better in a sense where we want to check if a lightweight OIDC service should be used, so that PR is needed anyway.
sberyozkin
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are not required and it's failing on Windows as Docker is not available.