-
Notifications
You must be signed in to change notification settings - Fork 3k
Use Google EU mirror for Maven Central #1509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,10 @@ | ||
| <settings> | ||
| <mirrors> | ||
| <mirror> | ||
| <id>jboss-public-repository-group</id> | ||
| <mirrorOf>*,!quarkus-nexus-release,!quarkus-nexus-snapshot</mirrorOf> | ||
| <name>jboss</name> | ||
| <url>http://repository.jboss.org/nexus/content/groups/developer/</url> | ||
| <id>google-maven-central</id> | ||
| <name>GCS Maven Central mirror EU</name> | ||
| <url>https://maven-central-eu.storage-download.googleapis.com/repos/central/data/</url> | ||
| <mirrorOf>central</mirrorOf> | ||
| </mirror> | ||
| </mirrors> | ||
| <profiles> | ||
| <profile> | ||
| <id>jboss-nexus</id> | ||
| <repositories> | ||
| <repository> | ||
| <id>jboss-public-repository-group</id> | ||
| <name>JBoss Public Repository Group</name> | ||
| <url>http://repository.jboss.org/nexus/content/groups/public/</url> | ||
| <layout>default</layout> | ||
| <releases> | ||
| <enabled>true</enabled> | ||
| <updatePolicy>never</updatePolicy> | ||
| </releases> | ||
| <snapshots> | ||
| <enabled>true</enabled> | ||
| <updatePolicy>never</updatePolicy> | ||
| </snapshots> | ||
| </repository> | ||
| </repositories> | ||
| </profile> | ||
| </profiles> | ||
| <activeProfiles> | ||
| <activeProfile>jboss-nexus</activeProfile> | ||
| </activeProfiles> | ||
| </settings> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure you need to keep the JBoss Nexus repository as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. It's declared in the pom themselves as we could not remove it from there (see the root pom.xml).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, yes I'm aware of the mention in the pom.xml.
We still need the JBoss Nexus repo though. Not saying that your change is breaking, but it would be cleared to have the server id made explicit here. But as you wish, it was meant as a minor comment.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW why the EU mirror? is our CI running in EU?
If that's the case you might be better of with the official Maven mirror for europe:
I didn't suggest that as I was assuming the Azure pipeline was running in US.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason why I removed it from there is that it doesn't break anything to remove it as it's declared in the parent pom and I would have had to redeclare Maven central here to be sure it's taken first.
In any case, we will go the Stuart's way on this and have a dedicated mirror set up on Azure.
This PR is here as a backup plan if we have any issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sanne so I asked Stuart and he said our instances are in West Europe. That's why I chose this mirror (and it's indeed faster than the US based one).
About the UK mirror, I'm a bit worried that they might have limitations similar to Maven Central itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍