Skip to content

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Mar 15, 2019

No description provided.

@gsmet gsmet changed the title [DO NOT MERGE] Use Google EU mirror for Maven Central Use Google EU mirror for Maven Central Mar 15, 2019
<id>google-maven-central</id>
<name>GCS Maven Central mirror EU</name>
<url>https://maven-central-eu.storage-download.googleapis.com/repos/central/data/</url>
<mirrorOf>central</mirrorOf>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure you need to keep the JBoss Nexus repository as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It's declared in the pom themselves as we could not remove it from there (see the root pom.xml).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, yes I'm aware of the mention in the pom.xml.

We still need the JBoss Nexus repo though. Not saying that your change is breaking, but it would be cleared to have the server id made explicit here. But as you wish, it was meant as a minor comment.

Copy link
Member

@Sanne Sanne Mar 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW why the EU mirror? is our CI running in EU?

If that's the case you might be better of with the official Maven mirror for europe:

   <id>UK</id>
   <name>UK Central</name>
   <url>http://uk.maven.org/maven2</url>
   <mirrorOf>central</mirrorOf>
 </mirror>

I didn't suggest that as I was assuming the Azure pipeline was running in US.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason why I removed it from there is that it doesn't break anything to remove it as it's declared in the parent pom and I would have had to redeclare Maven central here to be sure it's taken first.

In any case, we will go the Stuart's way on this and have a dedicated mirror set up on Azure.

This PR is here as a backup plan if we have any issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sanne so I asked Stuart and he said our instances are in West Europe. That's why I chose this mirror (and it's indeed faster than the US based one).

About the UK mirror, I'm a bit worried that they might have limitations similar to Maven Central itself.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

</build>

<repositories>
<repository>
Copy link
Member

@Sanne Sanne Mar 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove this? I'm trying to get rid of <repository> elements so this is going into the wrong direction :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So for this one:

  • we need it as long as we have JBoss Nexus declared to be sure we try Central first;
  • we can remove it as soon as the JBoss Nexus repo is deleted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so if you merge my other PR already this can get removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly. And done!

@gsmet gsmet changed the title Use Google EU mirror for Maven Central [DO NOT MERGE] Use Google EU mirror for Maven Central Mar 15, 2019
@gsmet gsmet force-pushed the google-eu-mirror branch from 4c0d465 to 30dbb35 Compare March 15, 2019 14:01
@gsmet gsmet changed the title [DO NOT MERGE] Use Google EU mirror for Maven Central Use Google EU mirror for Maven Central Mar 15, 2019
@Sanne Sanne merged commit 5cf4e10 into quarkusio:master Mar 15, 2019
@gsmet gsmet added this to the 0.12.0 milestone Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants