-
Notifications
You must be signed in to change notification settings - Fork 3k
Use Google EU mirror for Maven Central #1509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
<id>google-maven-central</id> | ||
<name>GCS Maven Central mirror EU</name> | ||
<url>https://maven-central-eu.storage-download.googleapis.com/repos/central/data/</url> | ||
<mirrorOf>central</mirrorOf> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure you need to keep the JBoss Nexus repository as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. It's declared in the pom themselves as we could not remove it from there (see the root pom.xml).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, yes I'm aware of the mention in the pom.xml.
We still need the JBoss Nexus repo though. Not saying that your change is breaking, but it would be cleared to have the server id made explicit here. But as you wish, it was meant as a minor comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW why the EU mirror? is our CI running in EU?
If that's the case you might be better of with the official Maven mirror for europe:
<id>UK</id>
<name>UK Central</name>
<url>http://uk.maven.org/maven2</url>
<mirrorOf>central</mirrorOf>
</mirror>
I didn't suggest that as I was assuming the Azure pipeline was running in US.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason why I removed it from there is that it doesn't break anything to remove it as it's declared in the parent pom and I would have had to redeclare Maven central here to be sure it's taken first.
In any case, we will go the Stuart's way on this and have a dedicated mirror set up on Azure.
This PR is here as a backup plan if we have any issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sanne so I asked Stuart and he said our instances are in West Europe. That's why I chose this mirror (and it's indeed faster than the US based one).
About the UK mirror, I'm a bit worried that they might have limitations similar to Maven Central itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
independent-projects/arc/pom.xml
Outdated
</build> | ||
|
||
<repositories> | ||
<repository> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you remove this? I'm trying to get rid of <repository>
elements so this is going into the wrong direction :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So for this one:
- we need it as long as we have JBoss Nexus declared to be sure we try Central first;
- we can remove it as soon as the JBoss Nexus repo is deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so if you merge my other PR already this can get removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly. And done!
No description provided.