Add Maven Wrapper to generated projects #1507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
reviewed
Mar 15, 2019
devtools/maven/src/main/java/io/quarkus/maven/CreateProjectMojo.java
Outdated
Show resolved
Hide resolved
gsmet
requested changes
Mar 15, 2019
geoand
force-pushed
the
wrapper-in-generated-projects
branch
from
f581b36 to
97ea114
Compare
|
@gsmet Hardcoded values removed |
gsmet
reviewed
Mar 15, 2019
geoand
force-pushed
the
wrapper-in-generated-projects
branch
from
97ea114 to
84b7d58
Compare
|
@gsmet OK to merge now? |
gsmet
reviewed
Mar 15, 2019
devtools/maven/src/main/java/io/quarkus/maven/CreateProjectMojo.java
Outdated
Show resolved
Hide resolved
gsmet
reviewed
Mar 15, 2019
geoand
force-pushed
the
wrapper-in-generated-projects
branch
from
84b7d58 to
230321b
Compare
|
PR rebased onto latest master to fix a conflict in the rest client guide |
geoand
force-pushed
the
wrapper-in-generated-projects
branch
from
230321b to
74f6f69
Compare
geoand
force-pushed
the
wrapper-in-generated-projects
branch
from
74f6f69 to
709d68b
Compare
gsmet
approved these changes
Mar 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1498