Add maven wrapper to the generated projects

[geoand]

It makes sense to add the maven wrapper to the generated projects (and to the quickstarts) in order to avoid problems were users are using a wrong maven version.

@gsmet @cescoffier Do you agree? If so, I can implement this

[fbricon]

Err... is it me or it doesn't work?

➜  souk mvn io.quarkus:quarkus-maven-plugin:0.12.0:create \
    -DprojectGroupId=foo.bar \
    -DprojectArtifactId=todo-quarked \
    -DclassName="foo.bar.GreetingResource" \
    -Dpath="/hello"
...
[INFO]
[INFO] Maven Wrapper version 0.5.3 has been successfully set up for your project.
[INFO] Using Apache Maven: 3.6.0
[INFO] Repo URL in properties file: https://repo.maven.apache.org/maven2
[INFO]
[INFO]
[INFO] ========================================================================================
[INFO] Your new application has been created in /Users/fbricon/Dev/souk/todo-quarked
[INFO] Navigate into this directory and launch your application with mvn compile quarkus:dev
[INFO] Your application will be accessible on http://localhost:8080
[INFO] ========================================================================================
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  6.927 s
[INFO] Finished at: 2019-03-23T13:18:01-04:00
[INFO] ------------------------------------------------------------------------
➜  souk cd /Users/fbricon/Dev/souk/todo-quarked
➜  todo-quarked ./mvnw quarkus:list-extensions
zsh: no such file or directory: ./mvnw
➜  todo-quarked la
total 16
-rw-r--r--  1 fbricon  staff    53B 23 Mar 13:17 .dockerignore
-rw-r--r--  1 fbricon  staff   3.5K 23 Mar 13:17 pom.xml
drwxr-xr-x  4 fbricon  staff   128B 23 Mar 13:17 src
drwxr-xr-x  6 fbricon  staff   192B 23 Mar 13:19 target

[gsmet]

@fbricon by any chance, was it installed in the souk directory?

[fbricon]

yup. Looks like someone blindly merged a PR without testing it first ;-)

[gsmet]

Yes and no :). The issue is that the project creation has a different behavior depending on if you are in an empty directory or not. If you are in an empty directory, it will work as expected and that's what was tested. If you are not in an empty directory, the project is created in a new directory and the wrapper should also be installed in it. I'm not a big fan of this behavior but @cescoffier disagrees with me :). I will create another issue for this. Thanks for reporting.

…

On Sat, Mar 23, 2019 at 10:11 PM Fred Bricon ***@***.***> wrote: yup. Looks like someone blindly merged a PR without testing it first ;-) — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#1498 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABOHBeceUV0Pm-iUbjLkn9mrfAOxRMclks5vZpicgaJpZM4b03KN> .