Skip to content

fix: added check to check if package.json contains output #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2024
Merged

fix: added check to check if package.json contains output #786

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f133aee
fix: added check to check if package.json contains output
zZHorizonZz Oct 14, 2024
8ee353a
fix: use default value
zZHorizonZz Oct 14, 2024
2be38c0
chore: rename OUTPUT to EXPECTED_OUTPUT_VALUE
zZHorizonZz Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...ment/src/main/java/io/quarkiverse/quinoa/deployment/framework/override/NextFramework.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
public class NextFramework extends GenericFramework {

private static final Logger LOG = Logger.getLogger(NextFramework.class);
private static final String OUTPUT = "export";

public NextFramework() {
super("out", "dev", 3000);
Expand All @@ -31,8 +32,8 @@ public QuinoaConfig override(QuinoaConfig delegate, Optional<JsonObject> package
LOG.warn(
"Make sure you define \"build\": \"next build \", in the package.json to make Next work with Quinoa.");
}
String output = packageJson.get().getString("output");
if (!"export".equals(output)) {

if (!packageJson.get().containsKey("output") || !OUTPUT.equals(packageJson.get().getString("output"))) {
LOG.warn(
"Make sure you define \"output\": \"export \", in the package.json to make Next work with Quinoa.");
}
Expand Down