Skip to content

Conversation

@zZHorizonZz
Copy link
Member

Describe your changes

This PR adds a check to ensure that if package.json doesn't contain an output field, we don't get a null pointer exception, but instead, get an appropriate warning.

Error in question:

[error]: Build step io.quarkiverse.quinoa.deployment.QuinoaProcessor#prepareQuinoaDirectory threw an exception: java.lang.NullPointerException: Cannot invoke "jakarta.json.JsonString.getString()" because the return value of "org.eclipse.parsson.JsonObjectBuilderImpl$JsonObjectImpl.getJsonString(String)" is null
[ERROR] 	at org.eclipse.parsson.JsonObjectBuilderImpl$JsonObjectImpl.getString(JsonObjectBuilderImpl.java:249)
[ERROR] 	at io.quarkiverse.quinoa.deployment.framework.override.NextFramework.override(NextFramework.java:34)
[ERROR] 	at io.quarkiverse.quinoa.deployment.framework.FrameworkType.overrideConfig(FrameworkType.java:91)
[ERROR] 	at io.quarkiverse.quinoa.deployment.QuinoaProcessor.prepareQuinoaDirectory(QuinoaProcessor.java:109)
[ERROR] 	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733)
[ERROR] 	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
[ERROR] 	at io.quarkus.builder.BuildContext.run(BuildContext.java:256)
[ERROR] 	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
[ERROR] 	at org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2516)
[ERROR] 	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2495)
[ERROR] 	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1521)
[ERROR] 	at java.base/java.lang.Thread.run(Thread.java:1570)
[ERROR] 	at org.jboss.threads.JBossThread.run(JBossThread.java:483)

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@zZHorizonZz zZHorizonZz requested a review from a team as a code owner October 14, 2024 12:31
Copy link
Collaborator

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@melloware melloware merged commit e322a2f into quarkiverse:main Oct 14, 2024
2 checks passed
@melloware
Copy link
Contributor

@all-contributors add @zZHorizonZz for code,bug

@allcontributors
Copy link
Contributor

@melloware

I've put up a pull request to add @zZHorizonZz! 🎉

@zZHorizonZz zZHorizonZz deleted the fix/error-output branch October 14, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants