Skip to content

Force encoding in reading of setup.cfg to utf-8 #4329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 10, 2021
Merged

Force encoding in reading of setup.cfg to utf-8 #4329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
caba630
Force encoding in reading of setup.cfg to utf-8
MuellerSeb Apr 9, 2021
d05c28d
Add Sebastian Müller to contributors
MuellerSeb Apr 9, 2021
af5c1f2
Add setup.cfg utf8 fix to changelog
MuellerSeb Apr 9, 2021
64a13cd
add missing empty line
MuellerSeb Apr 9, 2021
8a096b9
move changes to v2.7.5
MuellerSeb Apr 10, 2021
d284972
Merge branch 'master' into fix_setupcfg_utf8_encoding
Pierre-Sassoulas Apr 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CONTRIBUTORS.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,3 +468,5 @@ contributors:
* James Sinclair (irgeek): contributor

* Andreas Finkler: contributor

* Sebastian Müller: contributor
4 changes: 4 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ Release date: Undefined

* Don't show ``DuplicateBasesError`` for attribute access

* Fix crash when checking ``setup.cfg`` for pylint config when there are non-ascii characters in there

Closes #4328

* Allow code flanked in backticks to be skipped by spellchecker

Closes #4319
Expand Down
2 changes: 1 addition & 1 deletion pylint/config/find_default_config_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def _toml_has_config(path):

def _cfg_has_config(path):
parser = configparser.ConfigParser()
parser.read(path)
parser.read(path, encoding="utf-8")
return any(section.startswith("pylint.") for section in parser.sections())


Expand Down