Force encoding in reading of setup.cfg to utf-8 #4329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I can't tell if the failing pre-commit check is important or not. Otherwise this PR is ready for review from my side. |
cdce8p
reviewed
Apr 9, 2021
Pierre-Sassoulas
approved these changes
Apr 9, 2021
Member
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Thanks for troubleshooting this and opening a pull request !
cdce8p
reviewed
Apr 9, 2021
Member
|
Thank you for fixing this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
doc/whatsnew/<current release.rst>.Description
Pylint crashed when trying to read setup.cfg with non-ascii characters.
Type of Changes
Force encoding to be
"utf-8"in_cfg_has_config.Related Issue
Closes #4328