Add /proc/swaps collector #3428
Merged
+190
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance to get a quick review from you @discordianfish ? Possibly @tiraboschi from you? |
fabiand
commented
Sep 24, 2025
|
@rexagod maybe from you? |
Building on prometheus/procfs#246 this PR is introducing metrics around swap devices. Today metrics around swap are already available, but they are on the node level. With this PR, metrics are now available per device. Relates to: prometheus#1890 Signed-off-by: Fabian Deutsch <[email protected]> Co-authored-by: claude.ai
Signed-off-by: Fabian Deutsch <[email protected]>
Signed-off-by: Fabian Deutsch <[email protected]>
SuperQ
reviewed
Sep 27, 2025
Signed-off-by: Fabian Deutsch <[email protected]>
|
Morning. Is there something else that is missing? |
tiraboschi
reviewed
Sep 30, 2025
I think we have also to announce it on README.md |
Signed-off-by: Fabian Deutsch <[email protected]>
Signed-off-by: Fabian Deutsch <[email protected]>
|
Good point, thanks. Added to README and CHANGELOG |
tiraboschi
approved these changes
Sep 30, 2025
machine424
reviewed
Oct 6, 2025
machine424
reviewed
Oct 6, 2025
machine424
reviewed
Oct 6, 2025
machine424
reviewed
Oct 6, 2025
Signed-off-by: Fabian Deutsch <[email protected]>
Signed-off-by: Fabian Deutsch <[email protected]>
Signed-off-by: Fabian Deutsch <[email protected]>
Signed-off-by: Fabian Deutsch <[email protected]>
Signed-off-by: Fabian Deutsch <[email protected]>
Signed-off-by: Fabian Deutsch <[email protected]>
Signed-off-by: Fabian Deutsch <[email protected]>
Signed-off-by: Fabian Deutsch <[email protected]>
|
Argh. making lint happy. |
Signed-off-by: Fabian Deutsch <[email protected]>
Signed-off-by: Fabian Deutsch <[email protected]>
SuperQ
reviewed
Oct 6, 2025
Signed-off-by: Fabian Deutsch <[email protected]>
SuperQ
approved these changes
Oct 6, 2025
|
Thanks a lot for the reviews! |
|
Going to ignore the broken FreeBSD build, seems unrelated. |
SuperQ
added a commit
that referenced
this pull request
Oct 22, 2025
* [CHANGE] mdadm: Use sysfs for RAID metrics #3031 * [CHANGE] filesystem: Add erofs in default excluded fs #3313 * [CHANGE] tcpstat: Use std lib binary.NativeEndian #3386 * [FEATURE] pcidevice: Add new collector for PCIe devices #3339 * [FEATURE] AIX: Add more metrics #3338 * [FEATURE] systemd: Add Virtualization metrics #3254 * [FEATURE] swaps: Add new collector #3428 * [ENHANCEMENT] filesystem: Take super options into account for read-only #3387 * [ENHANCEMENT] perf: Add tlb_data metrics #3436 * [BUGFIX] interrupts: Fix OpenBSD interrupt device parsing #3288 * [BUGFIX] diskstats: Simplify condition #3290 * [BUGFIX] thermal: Sanitize darwin thermal strings #3294 * [BUGFIX] filesystem: Fix Darwin collector cgo memory leak #3315 * [BUGFIX] ethtool: Fix returning 0 for sanitized metrics #3335 * [BUGFIX] netdev: Fix Darwin netdev i/o bytes metric #3336 * [BUGFIX] systemd: Fix logging race #3364 * [BUGFIX] filesystem: Fix duplicate Darwin CGO import #3391 Signed-off-by: Ben Kochie <[email protected]>
Merged
SuperQ
added a commit
that referenced
this pull request
Oct 23, 2025
* [CHANGE] mdadm: Use sysfs for RAID metrics #3031 * [CHANGE] filesystem: Add erofs in default excluded fs #3313 * [CHANGE] tcpstat: Use std lib binary.NativeEndian #3386 * [FEATURE] pcidevice: Add new collector for PCIe devices #3339 * [FEATURE] AIX: Add more metrics #3338 * [FEATURE] systemd: Add Virtualization metrics #3254 * [FEATURE] swaps: Add new collector #3428 * [ENHANCEMENT] filesystem: Take super options into account for read-only #3387 * [ENHANCEMENT] perf: Add tlb_data metrics #3436 * [BUGFIX] interrupts: Fix OpenBSD interrupt device parsing #3288 * [BUGFIX] diskstats: Simplify condition #3290 * [BUGFIX] thermal: Sanitize darwin thermal strings #3294 * [BUGFIX] filesystem: Fix Darwin collector cgo memory leak #3315 * [BUGFIX] ethtool: Fix returning 0 for sanitized metrics #3335 * [BUGFIX] netdev: Fix Darwin netdev i/o bytes metric #3336 * [BUGFIX] systemd: Fix logging race #3364 * [BUGFIX] filesystem: Fix duplicate Darwin CGO import #3391 Signed-off-by: Ben Kochie <[email protected]>
SuperQ
added a commit
that referenced
this pull request
Oct 24, 2025
* [CHANGE] mdadm: Use sysfs for RAID metrics #3031 * [CHANGE] filesystem: Add erofs in default excluded fs #3313 * [CHANGE] tcpstat: Use std lib binary.NativeEndian #3386 * [FEATURE] pcidevice: Add new collector for PCIe devices #3339 * [FEATURE] AIX: Add more metrics #3338 * [FEATURE] systemd: Add Virtualization metrics #3254 * [FEATURE] swaps: Add new collector #3428 * [ENHANCEMENT] filesystem: Take super options into account for read-only #3387 * [ENHANCEMENT] perf: Add tlb_data metrics #3436 * [BUGFIX] interrupts: Fix OpenBSD interrupt device parsing #3288 * [BUGFIX] diskstats: Simplify condition #3290 * [BUGFIX] thermal: Sanitize darwin thermal strings #3294 * [BUGFIX] filesystem: Fix Darwin collector cgo memory leak #3315 * [BUGFIX] ethtool: Fix returning 0 for sanitized metrics #3335 * [BUGFIX] netdev: Fix Darwin netdev i/o bytes metric #3336 * [BUGFIX] systemd: Fix logging race #3364 * [BUGFIX] filesystem: Fix duplicate Darwin CGO import #3391 Signed-off-by: Ben Kochie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on prometheus/procfs#246 this PR is introducing metrics around swap devices.
Today metrics around swap are already available, but they are on the node level. With this PR, metrics are now available per device.
The use-case is to differentiate between different swap devices exhibiting different performance characteristics.
Relates to: #1890