Skip to content

Conversation

@SuperQ
Copy link
Member

@SuperQ SuperQ commented Mar 28, 2025

Sanitize zero terminated strings from OpenBSD device name parsing.

  • Add byte-to-string util function.

Fixes: #3287

@SuperQ SuperQ force-pushed the superq/fix_openbsd_intr branch 2 times, most recently from 3b99839 to 00be0f9 Compare March 28, 2025 09:00
@SuperQ SuperQ requested a review from discordianfish March 28, 2025 09:06
@SuperQ SuperQ force-pushed the superq/fix_openbsd_intr branch from 00be0f9 to e381429 Compare March 28, 2025 09:49
@SuperQ SuperQ requested a review from jkroepke March 28, 2025 09:54
Copy link
Member

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have some questions in my mind.

@SuperQ SuperQ force-pushed the superq/fix_openbsd_intr branch from e381429 to 1a089e0 Compare March 31, 2025 04:22
Sanitize zero terminated strings from OpenBSD device name parsing.
* Add byte-to-string util function.

Fixes: #3287

Signed-off-by: Ben Kochie <[email protected]>
@SuperQ SuperQ force-pushed the superq/fix_openbsd_intr branch from 1a089e0 to 0567b9c Compare March 31, 2025 04:22
@SuperQ SuperQ requested a review from jkroepke March 31, 2025 04:23
Copy link
Member

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, now I understand what happens here.

@SuperQ SuperQ merged commit 729a031 into master Mar 31, 2025
14 checks passed
@SuperQ SuperQ deleted the superq/fix_openbsd_intr branch March 31, 2025 09:00
SuperQ added a commit that referenced this pull request Oct 22, 2025
* [CHANGE] mdadm: Use sysfs for RAID metrics #3031
* [CHANGE] filesystem: Add erofs in default excluded fs #3313
* [CHANGE] tcpstat: Use std lib binary.NativeEndian #3386
* [FEATURE] pcidevice: Add new collector for PCIe devices #3339
* [FEATURE] AIX: Add more metrics #3338
* [FEATURE] systemd: Add Virtualization metrics #3254
* [FEATURE] swaps: Add new collector #3428
* [ENHANCEMENT] filesystem: Take super options into account for read-only #3387
* [ENHANCEMENT] perf: Add tlb_data metrics #3436
* [BUGFIX] interrupts: Fix OpenBSD interrupt device parsing #3288
* [BUGFIX] diskstats: Simplify condition #3290
* [BUGFIX] thermal: Sanitize darwin thermal strings #3294
* [BUGFIX] filesystem: Fix Darwin collector cgo memory leak #3315
* [BUGFIX] ethtool: Fix returning 0 for sanitized metrics #3335
* [BUGFIX] netdev: Fix Darwin netdev i/o bytes metric #3336
* [BUGFIX] systemd: Fix logging race #3364
* [BUGFIX] filesystem: Fix duplicate Darwin CGO import #3391

Signed-off-by: Ben Kochie <[email protected]>
@SuperQ SuperQ mentioned this pull request Oct 22, 2025
SuperQ added a commit that referenced this pull request Oct 23, 2025
* [CHANGE] mdadm: Use sysfs for RAID metrics #3031
* [CHANGE] filesystem: Add erofs in default excluded fs #3313
* [CHANGE] tcpstat: Use std lib binary.NativeEndian #3386
* [FEATURE] pcidevice: Add new collector for PCIe devices #3339
* [FEATURE] AIX: Add more metrics #3338
* [FEATURE] systemd: Add Virtualization metrics #3254
* [FEATURE] swaps: Add new collector #3428
* [ENHANCEMENT] filesystem: Take super options into account for read-only #3387
* [ENHANCEMENT] perf: Add tlb_data metrics #3436
* [BUGFIX] interrupts: Fix OpenBSD interrupt device parsing #3288
* [BUGFIX] diskstats: Simplify condition #3290
* [BUGFIX] thermal: Sanitize darwin thermal strings #3294
* [BUGFIX] filesystem: Fix Darwin collector cgo memory leak #3315
* [BUGFIX] ethtool: Fix returning 0 for sanitized metrics #3335
* [BUGFIX] netdev: Fix Darwin netdev i/o bytes metric #3336
* [BUGFIX] systemd: Fix logging race #3364
* [BUGFIX] filesystem: Fix duplicate Darwin CGO import #3391

Signed-off-by: Ben Kochie <[email protected]>
SuperQ added a commit that referenced this pull request Oct 24, 2025
* [CHANGE] mdadm: Use sysfs for RAID metrics #3031
* [CHANGE] filesystem: Add erofs in default excluded fs #3313
* [CHANGE] tcpstat: Use std lib binary.NativeEndian #3386
* [FEATURE] pcidevice: Add new collector for PCIe devices #3339
* [FEATURE] AIX: Add more metrics #3338
* [FEATURE] systemd: Add Virtualization metrics #3254
* [FEATURE] swaps: Add new collector #3428
* [ENHANCEMENT] filesystem: Take super options into account for read-only #3387
* [ENHANCEMENT] perf: Add tlb_data metrics #3436
* [BUGFIX] interrupts: Fix OpenBSD interrupt device parsing #3288
* [BUGFIX] diskstats: Simplify condition #3290
* [BUGFIX] thermal: Sanitize darwin thermal strings #3294
* [BUGFIX] filesystem: Fix Darwin collector cgo memory leak #3315
* [BUGFIX] ethtool: Fix returning 0 for sanitized metrics #3335
* [BUGFIX] netdev: Fix Darwin netdev i/o bytes metric #3336
* [BUGFIX] systemd: Fix logging race #3364
* [BUGFIX] filesystem: Fix duplicate Darwin CGO import #3391

Signed-off-by: Ben Kochie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panic: OpenBSD interrupts

3 participants