Skip to content

Fix PageHeader context bar font-weight #6256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025
+9 −4
Merged

Fix PageHeader context bar font-weight #6256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
164651c
fix weight
langermank Jun 30, 2025
37eb207
Create angry-boats-poke.md
langermank Jun 30, 2025
89f6bf2
Merge branch 'main' into fix-pageheader-weight
langermank Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/angry-boats-poke.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Fix PageHeader context bar `font-weight`
8 changes: 4 additions & 4 deletions packages/react/src/PageHeader/PageHeader.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
'description description description description description'
'navigation navigation navigation navigation navigation';

/*
/*
line-height is calculated with calc(height/font-size) and the below numbers are from @primer/primitives.
--custom-font-size, --custom-line-height, --custom-font-weight are custom properties that can be used to override the below values.
We don't want these values to be overridden but still want to allow consumers to override them if needed.
Expand Down Expand Up @@ -120,7 +120,7 @@
display: flex;
padding-bottom: var(--base-size-8);
font-size: var(--text-body-size-medium, 0.875rem);
font-weight: var(--base-text-weight-light);
font-weight: var(--base-text-weight-normal);
line-height: var(--text-body-lineHeight-medium, 1.4285);
flex-direction: row;
grid-row: var(--grid-row-order-context-area);
Expand Down Expand Up @@ -172,7 +172,7 @@
display: flex;
padding-right: var(--base-size-8);
font-size: var(--text-body-size-medium, 0.875rem);
font-weight: var(--base-text-weight-light);
font-weight: var(--base-text-weight-normal);
line-height: var(--text-body-lineHeight-medium, 1.4285);
grid-row: var(--grid-row-order-breadcrumbs);
grid-area: breadcrumbs;
Expand Down Expand Up @@ -242,7 +242,7 @@
display: block;
padding-top: var(--base-size-8);
font-size: var(--text-body-size-medium, 0.875rem);
font-weight: var(--base-text-weight-light);
font-weight: var(--base-text-weight-normal);
line-height: var(--text-body-lineHeight-medium, 1.4285);
grid-row: var(--grid-row-order-navigation);
grid-area: navigation;
Expand Down
Loading