Skip to content

Fix PageHeader context bar font-weight #6256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025
Merged

Conversation

langermank
Copy link
Contributor

Closes https://github.com/github/primer/issues/5382

I took a look at the prev. implementation before CSS Modules and best I can tell we didn't set the weight to light. I'm not sure if this was maybe an oversight?

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Jun 30, 2025

🦋 Changeset detected

Latest commit: 89f6bf2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jun 30, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-6256 June 30, 2025 21:36 Abandoned
Copy link
Contributor

github-actions bot commented Jun 30, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.48 KB (0%)
packages/react/dist/browser.umd.js 92.7 KB (0%)

@langermank langermank marked this pull request as ready for review June 30, 2025 21:57
@Copilot Copilot AI review requested due to automatic review settings June 30, 2025 21:57
@langermank langermank requested a review from a team as a code owner June 30, 2025 21:57
@langermank langermank requested a review from TylerJDev June 30, 2025 21:57
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@langermank langermank added this pull request to the merge queue Jun 30, 2025
Merged via the queue into main with commit 0318b4b Jun 30, 2025
35 checks passed
@langermank langermank deleted the fix-pageheader-weight branch June 30, 2025 22:21
@primer primer bot mentioned this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants