Skip to content

PageHeader: Fix shrinking Actions sub component in Safari #4738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2024
Merged

PageHeader: Fix shrinking Actions sub component in Safari #4738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1f37ce
PageHeader: Fix shrinking actions part in safari
broccolinisoup Jul 15, 2024
b2fdca3
Create slow-rivers-know.md
broccolinisoup Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slow-rivers-know.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

PageHeader: Fix shrinking Actions sub component in Safari
2 changes: 1 addition & 1 deletion packages/react/src/PageHeader/PageHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ const Actions: React.FC<React.PropsWithChildren<ChildrenPropTypes>> = ({
flexDirection: 'row',
paddingLeft: '0.5rem',
gap: '0.5rem',
flexGrow: '1',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flexGrow doesn't have any impact since the parent is grid. I removed this.

minWidth: 'max-content',
justifyContent: 'right',
alignItems: 'center',
},
Expand Down