PageHeader: Fix shrinking Actions sub component in Safari
#4738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b2fdca3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
commented
Jul 15, 2024
| @@ -577,7 +577,7 @@ const Actions: React.FC<React.PropsWithChildren<ChildrenPropTypes>> = ({ | |||
| flexDirection: 'row', | |||
| paddingLeft: '0.5rem', | |||
| gap: '0.5rem', | |||
| flexGrow: '1', | |||
There was a problem hiding this comment.
flexGrow doesn't have any impact since the parent is grid. I removed this.
broccolinisoup
changed the title
Actions sub component in Safari
joshblack
approved these changes
Jul 16, 2024
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/333695 |
Merged
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally reported on Slack. Team has a proposed solution at dotcom but it also works in the component, so I upstreamed the solution.
Please see the screenshot in the issue. (It is internally shared)
Changelog
New
min-width: 'max-content'to the Actions sub component to prevent Safari from shrinking the actions part of the PageHeader.Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist