Fix solver implementations #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanaelbosch
requested changes
Oct 18, 2022
nathanaelbosch
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, most of the solvers do not work as expected. For example, only the KroneckerEK0 from the readme solves the ODE successfully, the others fail with a linear-algebra error. The reason is that the
jax.scipy.linalg.qr(..., mode="r")output type has changed: it always returns a tuple of matrices.See: jax-ml/jax#10452
While at it, I also changed the jax+jaxlib requirement to a jax[cpu] requirement and ran
pre-commit autoupdate.