Skip to content

Conversation

ruslandoga
Copy link

@ruslandoga ruslandoga commented Mar 10, 2025

This should be enough to allow Plausible.Mailer handle/suppress hard bounces.

Maybe with something like this:

defmodule Plausible.SentryFilter do
  # ...
  def before_send(%{original_exception: %Bamboo.PostmarkAdapter.Error{} = e} = event) do
    unless Bamboo.PostmarkAdapter.Error.is_hard_bounce(e), do: event
  end
end

It also fixes invalid (non-text :message) Bamboo.ApiErrors.

Related:

@ruslandoga
Copy link
Author

cc @plausible/oss-developers

@ruslandoga ruslandoga changed the title use custom error for better introspection use custom error for better introspection, fix other errors Mar 10, 2025
@aerosol
Copy link
Member

aerosol commented Mar 11, 2025

I don't seem to have merge permissions here.

@aerosol
Copy link
Member

aerosol commented Mar 13, 2025

@ukutaht can you merge?

@ukutaht ukutaht merged commit c6a773d into plausible:main Mar 17, 2025
@ukutaht
Copy link

ukutaht commented Mar 17, 2025

Merged. Also you should have merge permissions now @aerosol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants