Log Mailer errors #4885
Merged
Log Mailer errors #4885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ruslandoga
commented
Dec 6, 2024
zoldar
approved these changes
Dec 18, 2024
|
@ukutaht double checking if it's OK to merge? |
|
ruslandoga
force-pushed
the
log-mailer-errors-in-ce
branch
from
529bb35 to
b7e5a5d
Compare
ruslandoga
commented
Dec 23, 2024
ruslandoga
force-pushed
the
log-mailer-errors-in-ce
branch
from
b7e5a5d to
3ee5945
Compare
ukutaht
approved these changes
Jan 2, 2025
ruslandoga
added a commit
that referenced
this pull request
Jan 6, 2025
ruslandoga
added a commit
that referenced
this pull request
Jan 6, 2025
ruslandoga
added a commit
that referenced
this pull request
Jan 6, 2025
ruslandoga
added a commit
that referenced
this pull request
Jan 16, 2025
|
Possible fix for "hard bounce" Bamboo.ApiError Sentry flood: plausible/bamboo_postmark#3 |
ukutaht
pushed a commit
to plausible/bamboo_postmark
that referenced
this pull request
Mar 17, 2025
This should be enough to allow Plausible.Mailer handle/suppress hard
bounces.
Maybe with something like this:
```elixir
defmodule Plausible.SentryFilter do
# ...
def before_send(%{original_exception: %Bamboo.PostmarkAdapter.Error{} = e} = event) do
unless Bamboo.PostmarkAdapter.Error.is_hard_bounce(e), do: event
end
end
```
It also fixes invalid (non-text `:message`) `Bamboo.ApiError`s.
Related:
- plausible/analytics#4885
-
https://github.com/beam-community/bamboo/blob/main/lib/bamboo/api_error.ex
- https://sentry.plausible.io/organizations/plausible/issues/756
-
https://github.com/plausible/analytics/blob/master/lib/sentry_filter.ex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR improves Plausible.Mailer error messages in CE.
Requested in #4844 (comment)