-
Notifications
You must be signed in to change notification settings - Fork 5
Hda library #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Hda library #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Session sync logging
Hda tab code review
- Replace repetitive if/elif chains in add_parm_ui() with cleaner m…
Refactor build workflow to use 'main' branch and simplify job steps
…ating README handling
…ow to fix image paths when it makes the submodule
## Added Features ### Core API (C++) - `get_hda_libraries()` - Query all loaded HDA libraries with metadata - `load_hda_library(file_path)` - Load HDA libraries from file paths - `get_library_info(library_id)` - Get library details by ID - `get_user_hda_libraries()` - Filter user-loaded libraries (excludes built-ins) - `scan_user_hda_directories()` - Return common user HDA directory paths - Added `explicitly_loaded_libraries` tracking array ### UI Components - **Library tab** (`ui/hego_control_library.tscn`, `ui/library_control.gd`) - Tree view for available/cached libraries organized by directory - Add/remove libraries with bulk directory operations - JSON persistence to `res://hego_library.json` - **Asset picker dialog** (`ui/asset_picker_dialog.tscn`, `ui/asset_picker_dialog.gd`) - Tree view of cached library assets - Direct JSON file reading - **HEGoNode3D inspector integration** - Added "Select HDA" button using `@export_tool_button` - Opens asset picker dialog, populates `asset_name` property ### Session Management - Enhanced plugin cleanup with proper Houdini session termination - Memory cleanup for library tracking on exit ## Modified Files **Core API:** `src/hego_api.h`, `src/hego_api.cpp` **Godot Integration:** `demo/addons/hego/HEGoNode3D.gd`, `demo/addons/hego/hego.gd`, `demo/addons/hego/hego_control.tscn` **UI System:** `demo/addons/hego/ui/library_control.gd`, `demo/addons/hego/ui/hego_control_library.tscn`, `demo/addons/hego/ui/asset_picker_dialog.gd`, `demo/addons/hego/ui/asset_picker_dialog.tscn`, `demo/addons/hego/ui/hego_control.gd`
… it won't crash just log it out
This was referenced Jul 21, 2025
Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good! On the c++ side I'd use the get_string(session, string_handle) function in hego_util though, will save a couple lines and be more readable. Feel free to add in the result checks there to be safe.
Will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HDA Library Management & Asset Picker System
Overview
Adds comprehensive HDA library management with directory-based organization, fuzzy search asset picker, and robust error handling. Solves the "finding HDAs in a sea of built-ins" problem and provides a smooth workflow for HDA selection and management.
Core Features
🏗️ HDA Library Management API (C++)
get_hda_libraries()
,load_hda_library()
,get_library_info()
,get_user_hda_libraries()
🎨 Library Management UI
res://hego_library.json
for fast access🔍 Fuzzy Search Asset Picker
🛡️ License Failure Resilience
HOUDINI_CHECK_ERROR_RETURN
prevents session corruption🔄 Asset Switching Improvements
reset_node_id()
binding ensures fresh asset creationTechnical Implementation
Modified Files:
src/hego_api.{h,cpp}
- Core library management APIsrc/hego_nodes/hego_asset_node.cpp
- Error handling and method bindingssrc/util/node/create_nodes.cpp
- License-safe node creationdemo/addons/hego/HEGoNode3D.gd
- Asset picker integration and cleanupdemo/addons/hego/ui/
- Complete library management UI systemKey Patterns:
HOUDINI_CHECK_ERROR_RETURN
for graceful failuresDeveloper Impact
Before: Manual HDA path entry, crashes on license issues, mixed cached parameters
After: Visual HDA browser, fuzzy search, license-resilient operation, clean asset switching
Migration: Fully backward compatible - existing workflows unchanged, new features opt-in
This system transforms HDA workflow from tedious manual management to a polished, search-driven experience that handles real-world edge cases gracefully.