Skip to content

Conversation

@bennypowers
Copy link
Member

No description provided.

* fix(avatar)!: remove BaseAvatar

Closes #2617
Closes #2575
Closes #2349

* fix(avatar): update css
@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2024

🦋 Changeset detected

Latest commit: a21747a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bennypowers bennypowers marked this pull request as draft March 31, 2024 09:04
@github-actions github-actions bot added functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass tests Related to testing labels Mar 31, 2024
@netlify
Copy link

netlify bot commented Mar 31, 2024

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit a21747a
🔍 Latest deploy log https://app.netlify.com/sites/patternfly-elements/deploys/66bf3c031ccc5d0008e34d6f
😎 Deploy Preview https://deploy-preview-2734--patternfly-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the AT passed Automated testing has passed label Mar 31, 2024
@github-actions github-actions bot added the work in progress POC / Not ready for review label Mar 31, 2024
bennypowers and others added 5 commits March 31, 2024 13:27
* fix(clipboard-copy)!: remove BaseClipboardCopy

Closes #2611

* fix(clipboard-copy): use pfv4 styles

* fix(clipboard-copy)!: rename ClipboardCopyCopiedEvent to PfClipboardCopyCopiedEvent
* fix(switch)!: remove BaseSwitch

Closes #2618

* fix(switch): remove extra semicolon

* Merge branch 'staging/4.0' into fix/switch/remove-base

* fix(switch): svg namespace

---------

Co-authored-by: Steven Spriggs <[email protected]>
* fix(label)!: remove BaseLabel

Closes #2620

* feat(label): self-remove on close

* test(label): update tests

* fix(label): correct font-size unit, include missing pf global var

* docs(label): fix accesibility demo

* fix(label): removes the removal of element and only triggers close event

* fix(label): undo last commit, see the example in the changeset

---------

Co-authored-by: Steven Spriggs <[email protected]>
@github-actions github-actions bot added the doc label Apr 11, 2024
bennypowers and others added 5 commits April 11, 2024 08:53
* fix(card): moving styles and code from baseclass

* chore: changset

* feat(card): removing basecard class, styles

* fix(card): remove unused basecard import

* Update .changeset/sharp-spiders-float.md

Co-authored-by: Benny Powers <[email protected]>

* docs: make changeset major

* fix(card): make slot controller private

* feat(card): title slot, header actions

---------

Co-authored-by: Benny Powers <[email protected]>
Co-authored-by: Benny Powers <[email protected]>
@github-actions github-actions bot added the demo Updating demo pages label Apr 11, 2024
@github-actions
Copy link
Contributor

SSR Test Run for fa684b4: Report

@github-actions
Copy link
Contributor

SSR Test Run for 8d7cbed: Report

@github-actions
Copy link
Contributor

SSR Test Run for f763e59: Report

@github-actions
Copy link
Contributor

SSR Test Run for 4b659de: Report

@github-actions
Copy link
Contributor

SSR Test Run for ebe500d: Report

bennypowers and others added 2 commits July 15, 2024 11:28
* feat(core): add `@listen` decorator

* feat(core): add `@observes` decorator

* refactor: use new listen and observes decorators

* fix(core): listen decorator call lifecycle correctly

* test(core): observes decorator test

* feat(core): observes decorator options

waitFor option lets caller wait for connected, firstUpdated, or updated
until calling the method

* fix: observes calls

* fix(core): improved types

* fix(core): even better types

* test(core): listen decorator
@bennypowers bennypowers marked this pull request as draft July 18, 2024 14:26
bennypowers and others added 4 commits August 15, 2024 14:25
* fix(select): display value from attribute

* feat(select): typeahead

adds `ActivedescendantController` to core

* fix: wip activedescendantcontroller clone nodes

* fix(select): slightly less janky clonenode path

* refactor: iterative improvements

* fix(core)!: a11y controller options

* fix: elements usage of a11y controllers

* fix!: abstract ATFocusController

* fix!: inching towards correctness

* fix: give listbox controller access to control element

* fix: inching closer

* fix(core): index at focus item by number

* fix(select): typeahead, focus, filter

* fix(select): roles

* fix(select): combobox controller

* fix(select): combobox controller

works with orca ff, apparently

* fix(core): combobox

* fix(select): better vo support

* fix(select): activedescentant

* fix(select): dropdown orientation

* fix(core): listbox select

* fix: select, core jsdoc, cleanup

* fix(core): a more general combobox interface

* fix(core): more nitpicks

* fix(core): oopsies

forgot to commit these yesterday

* refactor(select): polish

* fix(tabs): update to use new rtic stuff

* fix(core): initial focus for rti

* fix(accordion): wip rtic migration

* test(accordion): update tests

* refactor(accordion): whitespace

* docs(accordion): focusable content in panel

* docs(accordion): demo formatting

* test(accordion): fix and refactor tests

* fix(core): off-by-one error in RTIC controller

* fix(core): nested rtic

* feat(tools): chai a11y snapshot assertions

* fix(core): more ssr-able controllers

* fix(core): more ssr-able controllers

* fix(core): more ssr-able controllers

* fix(icon): more ssr-able icon

* fix(core): remove unused ax controller apis

* test(core): observes decorator

* fix(chip): rtic apis, tests

* feat(tools): a11yShapshot queries can match regex

* chore: import maps in tests

* refactor(select): type assertion

* feat(tools): more ax assertions

* fix(core): listbox/combobox selection state

* fix(select): no placeholder label

* fix(select): checkboxes

* fix(core): listbox select behaviour

* feat(tools): more ax chai helpers

* docs(select): checkbox demo padding

* test(select): all green

* test: reporter in ci

* fix(tools): always junit reporter in ci

* chore: test runner config

* fix(tools): test runner config

* fix(tools): flatten assertions in ci

* test(select): summaries

* chore: update deps

* test: refactor ax helpers

* test(select): reformat test file

* test(select): taborder when bluring listbox

* test(select): format test file

* test(select): home/end should expand listbox

* test(select): show+home after selecting

* test(select): no scroll on space

* docs(select): demo containers

* fix(core): aria-multiselectable

* test(select): format test file

* fix(select): redundant button role

* fix: visually-hidden styles

* test(select): provisional home/end typeahead

* test(select): aria-posinset

* fix(core): listbox aria-posinset

* test(select): format file

* test(select): dont expand listbox on type space

* test(select): space on button no scroll

* fix(core): combobox prevent scroll

Also prevent listbox from showing on typing space in combobox input

* test(select): tabbing away does not focus button

* fix(core): combobox dont focus button on blur

* refactor(core): combobox listeners

* fix(core): home/end for combobox

* test(select): format file

* fix(select): ghost placeholder

* test(select): refactor

* test(select): cases involving labels and placeholders

* fix(core): placeholder/label/carat

* fix(select): focus styles

* fix(select): fallback label to placeholder

* fix(select): workaround for safari

* test(select): cases

* fix(select): inert instead of aria-hidden

* fix(core): safari workaround for activedescendant

* fix(core): wip single-vs-multiselect on click

* fix(core): multiselect click

* fix(select): checkbox label

* test(select): refactor tests

* feat(tools): test utils: allow clicking out of element bounds

* test(select): clicking items

* fix(core): clicking shadow ad items

* test(select): more better selected tests

* fix(core): clicking shadow items

* fix(core): more x-root aria shenanigans

* test(select): add lightdom options slotted test

* refactor(core): unused var

* test(core): test shadow-root-only combobox-controller

* test(core): combobox works even with no user-set ids

* fix(core): propertly detect rotten apples

* refactor(core): rename support boolean

* fix(core): ad controller works without preset ids

* fix(core): default isItemDisabled predicate

* test: try to deflake

* test(select): greg's issues when an item is selected

* refactor(core): controller field privacy

* fix(core): correct order of operations in combobox listeners

* refactor(core): override onKeydown

* fix(core): ensure compatibility in combobox controller

* test(core): combobox tests

* refactor(core): don't bind this in controller options

---------

Co-authored-by: Steven Spriggs <[email protected]>
@bennypowers bennypowers marked this pull request as ready for review August 16, 2024 05:37
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2024

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "chore: release 4.0"
}

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

SSR Test Run for b4ac8ff: Report

@github-actions
Copy link
Contributor

SSR Test Run for 8b156f4: Report

@github-actions
Copy link
Contributor

SSR Test Run for a0752fc: Report

@github-actions
Copy link
Contributor

SSR Test Run for 2dd0b68: Report

@bennypowers bennypowers merged commit c9bd577 into main Aug 16, 2024
@bennypowers bennypowers deleted the staging/4.0 branch August 16, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed demo Updating demo pages doc functionality Functionality, typically pertaining to the JavaScript. generator Updates relating to the generator styles An issue or PR pertaining only to CSS/Sass tests Related to testing tools Development and build tools work in progress POC / Not ready for review

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants