-
Notifications
You must be signed in to change notification settings - Fork 106
Closed
Description
Description of the issue
BaseAvatar implements its own size property
patternfly-elements/elements/pf-avatar/BaseAvatar.ts
Lines 28 to 29 in 905465f
| /** Size of the Avatar */ | |
| @property({ reflect: true }) size: 'sm'|'md'|'lg'|'xl' = 'sm'; |
this could present a problem in the future,
class JazzyAvatar extends BaseAvatar {
@property() size?: 'louis'|'miles'|'john'|'duke';
}Property 'size' in type 'JazzyAvatar' is not assignable to the same property in base type 'BaseAvatar'.
Type '"louis" | "miles" | "john" | "duke" | undefined' is not assignable to type '"sm" | "md" | "lg" | "xl"'.
Type 'undefined' is not assignable to type '"sm" | "md" | "lg" | "xl"'.
BaseAvatar's size property should be an abstract optional string