Skip to content

Conversation

@bennypowers
Copy link
Member

Closes #2437

What I did

  1. added renderTitleInOverview option to the custom-elements-manifest 11ty plugin.

Testing Instructions

  1. check the element docs pages on the DP, there should be no change, since the option defaults to true.

@changeset-bot
Copy link

changeset-bot bot commented Mar 26, 2023

🦋 Changeset detected

Latest commit: cd16676

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/pfe-tools Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bennypowers bennypowers requested a review from zeroedin March 26, 2023 09:29
@github-actions github-actions bot added generator Updates relating to the generator tools Development and build tools labels Mar 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2023

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit b8bd96b
😎 Deploy Preview https://deploy-preview-2444--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Mar 26, 2023
Copy link
Collaborator

@brianferry brianferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can see the header appear / disappear with the flag in the docspage, tested through rhds too and looks good there as well.

@bennypowers bennypowers merged commit 79f30b8 into main Mar 27, 2023
@bennypowers bennypowers deleted the fix/tools/cem-shortcode-headings branch March 27, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed generator Updates relating to the generator ready to merge tools Development and build tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<h1> duplicated on RHDS docs pages

3 participants