Skip to content

Conversation

@markcaron
Copy link
Contributor

Adding new image assets for header (in addition to favicons)

@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2023

⚠️ No Changeset found

Latest commit: 9357705

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the doc label Mar 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

👕 Commitlint Problems for this PR:

🔎 found 4 errors, 0 warnings
ℹ️ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

1f4b223 - Adding favicons

  • ❌ subject may not be empty
  • ❌ type may not be empty

416022d - Adding new PFE logo SVG

  • ❌ subject may not be empty
  • ❌ type may not be empty

@github-actions github-actions bot added the AT passed Automated testing has passed label Mar 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 6264c99
😎 Deploy Preview https://deploy-preview-2400--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added generator Updates relating to the generator tools Development and build tools labels Mar 2, 2023
@zeroedin
Copy link
Contributor

zeroedin commented Mar 2, 2023

I totally borked the rebase trying to reword Marks commits, I attempted to fix but figured was easier to cherry-pick his commits in a new branch PR then dealing with the force push here.

New PR: #2401

@zeroedin zeroedin closed this Mar 2, 2023
@zeroedin zeroedin deleted the docs/newheader branch August 25, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed generator Updates relating to the generator tools Development and build tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants