Skip to content

Conversation

@bennypowers
Copy link
Member

Closes #2376

What I did

  1. added an elementsDir option to pfe.config.json
  2. use that to compute demo paths, or default to elements

Testing Instructions

  1. copy the contents of custom-elements-manifest.cjs to node_modules/@patternfly/pfe-tools/11ty/plugins/custom-elements-manifest.cjs
  2. make sure both the dev server and the 11ty site demos work as expected

@bennypowers bennypowers requested a review from eyevana February 28, 2023 09:35
@changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2023

🦋 Changeset detected

Latest commit: af48ed4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/pfe-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the tools Development and build tools label Feb 28, 2023
@github-actions
Copy link
Contributor

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit d52eef6
😎 Deploy Preview https://deploy-preview-2394--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Feb 28, 2023
@eyevana
Copy link
Contributor

eyevana commented Feb 28, 2023

lgtm! :)

@eyevana eyevana merged commit f03a419 into main Feb 28, 2023
@eyevana eyevana deleted the fix/tools/docsTemplatePath branch February 28, 2023 20:59
zeroedin pushed a commit that referenced this pull request Mar 2, 2023
zeroedin pushed a commit that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed ready to merge tools Development and build tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[pfe-tools]: wrong docsTemplatePath generated for elements in custom elements manifest plugin

3 participants