Skip to content

fix: added border-box to panel to fix border offset #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylebuch8 merged 2 commits into from
Nov 16, 2021
Merged

fix: added border-box to panel to fix border offset #1810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bdf595
fix: added border-box to panel to fix border offset
heyMP Nov 16, 2021
399e606
chore: update changelog
heyMP Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG-1.x.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# TBD
- [](https://github.com/patternfly/patternfly-elements/commit/) fix: added border-box to panel to fix border offset

# 1.12.0 (2021-11-12)
- [b15c47](https://github.com/patternfly/patternfly-elements/commit/b15c476edcb803a1b972e91e048d5b897b64cc91) feat: Update pfe-clipboard so it can copy arbitrary content, and updated tests to new framework
- [f33ba4](https://github.com/patternfly/patternfly-elements/commit/f33ba4a9118454ec939a173f90ba0e0a5f1c96cd) feat: adds custom event for clear search event, adds an aria label for search button (when applicable), and resolves dupe "x" with input[type="search"]
Expand Down
3 changes: 2 additions & 1 deletion elements/pfe-accordion/src/pfe-accordion-panel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,13 @@
background-color: pfe-local(BackgroundColor, transparent);
color: pfe-local(Color);
box-shadow: pfe-local(BoxShadow);
box-sizing: border-box;

// Border settings
border-style: pfe-var(surface--border-style);
border-color: pfe-local(BorderColor);
border-width: pfe-local(BorderWidth);

// No visible top border on the panel is necessary
border-top-width: 0;
border-bottom-width: 0;
Expand Down