Skip to content

Conversation

@heyMP
Copy link
Contributor

@heyMP heyMP commented Nov 16, 2021

Adds box-sizing: border-box; to the accordion-panel. Corrects the border offset in the panels.

Related issues

Preview

Link(s) to demo page(s) where this element can be viewed:

Testing instructions

Example

Screen Shot 2021-11-16 at 8 41 37 AM

Example

Screen Shot 2021-11-16 at 8 42 15 AM

Browser requirements

Your component should work in all of the following environments:

  • Latest 2 versions of Edge
  • Internet Explorer 11 (should be useable, not pixel perfect)
  • Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
  • Firefox 78 (or latest version for Red Hat Enterprise Linux distribution)
  • Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
  • Latest 2 versions of Safari
  • Android mobile device (such as the Galaxy S9)
  • Apple mobile device (such as the iPhone X)
  • Apple tablet device (such as the iPhone Pro)

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Tests have been updated to cover these changes.
  • Browser testing passed.
  • Changelog updated.
  • Documentation (README.md, WHY.md, etc.) updated or added.
  • Link to the demo recording:
  • Approved by designer.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the [email protected] mailing list!

@heyMP heyMP added the fix label Nov 16, 2021
@github-actions github-actions bot added styles An issue or PR pertaining only to CSS/Sass AT passed Automated testing has passed labels Nov 16, 2021
@netlify
Copy link

netlify bot commented Nov 16, 2021

✔️ Deploy Preview for patternfly-elements ready!

🔨 Explore the source changes: 399e606

🔍 Inspect the deploy log: https://app.netlify.com/sites/patternfly-elements/deploys/6193b605902e4f00080db6e4

😎 Browse the preview: https://deploy-preview-1810--patternfly-elements.netlify.app

Copy link
Contributor

@kylebuch8 kylebuch8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local Grapes To Mead?

@kylebuch8 kylebuch8 enabled auto-merge (squash) November 16, 2021 13:55
@kylebuch8 kylebuch8 merged commit bf2088a into master Nov 16, 2021
@kylebuch8 kylebuch8 deleted the issue-1809-pfe-accordion-panel-border branch November 16, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed fix ready to merge styles An issue or PR pertaining only to CSS/Sass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants