Skip to content

fix: pfe-band regions overflow when text size increased #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
castastrophe wants to merge 5 commits into from
Closed

fix: pfe-band regions overflow when text size increased #1697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9d093b9
fix: pfe-band regions overflow when text size increased
castastrophe Jun 30, 2021
7a29c0e
fix: width from auto to unset
castastrophe Jun 30, 2021
d009fff
fix: Update changelog
castastrophe Jun 30, 2021
88be71f
fix: Remove unset for Width (empty hook); update grid-template-column…
castastrophe Jul 1, 2021
a7714c1
Merge branch 'master' of github.com:patternfly/patternfly-elements in…
castastrophe Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG-1.x.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# 1.10.2 (2021)

- [](https://github.com/patternfly/patternfly-elements/commit/) fix: Jump links parseInt for IE11
- [](https://github.com/patternfly/patternfly-elements/commit/) fix: pfe-band region overflow
- [5f88c39](https://github.com/patternfly/patternfly-elements/commit/5f88c3963f8a6c13a9aeba6e9f664678453d46ce) fix: Jump links parseInt for IE11

# 1.10.1 (2021-07-12)

Expand Down
11 changes: 8 additions & 3 deletions elements/pfe-band/src/pfe-band.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ $LOCAL-VARIABLES: (
gutter--horizontal: calc(#{pfe-var(container-spacer)} * 3),

// Band width logic
// Initialize at mobile breakpoint
Width: auto,
Width__aside--sm: 240px,
Width__aside--lg: 300px,
);
Expand Down Expand Up @@ -200,7 +198,7 @@ $regions-grid: (
@supports (display: grid) {
display: grid;
grid-template-rows: auto;
grid-template-columns: auto;
grid-template-columns: 100%;

grid-template-areas: "body";

Expand Down Expand Up @@ -339,6 +337,13 @@ slot[name="pfe-band--aside"] {
// Fallback margins if grid is not used
margin-bottom: pfe-local(gutter--vertical, $region: $section);
margin-right: pfe-local(gutter--vertical, $region: $section);
// Prevents page overflow when region content increases
max-width: inherit;

// Enforce container limits
@include browser-query(ie11) {
width: 100%;
}

// Apply the grid layout
@supports (display: grid) {
Expand Down
Loading