Skip to content

Conversation

@castastrophe
Copy link
Contributor

@castastrophe castastrophe commented Jun 30, 2021

Related issues

What has changed and why

  • Update default for max-width on mobile to unset instead of auto
  • Adding max-width: inherit to the band regions prevent them from overflowing their containers when the base typography is increased using the --pfe-global--FontSize attributes.

i.e.,

body {
    --pf-global--FontSize--sm: 1em;
    --pf-global--FontSize--md: 1.1em;
    --pf-global--FontSize--lg: 1.2em;
    --pf-global--FontSize--xl: 1.3em;
    --pf-global--FontSize--2xl: 1.4em;
    --pf-global--FontSize--3xl: 1.5em;
    --pf-global--FontSize--4xl: 1.6em;
    --pf-global--FontSize--5xl: 1.7em;
    --pf-global--FontSize--6xl: 1.8em;
}

Testing instructions

  • Test case 1
    1. Go here
    2. Do this
  • Test case 2
    1. Go here
    2. Do this

Browser requirements

Your component should work in all of the following environments:

  • Latest 2 versions of Edge
  • Internet Explorer 11 (should be useable, not pixel perfect)
  • Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
  • Firefox 78 (or latest version for Red Hat Enterprise Linux distribution)
  • Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
  • Latest 2 versions of Safari
  • Android mobile device (such as the Galaxy S9)
  • Apple mobile device (such as the iPhone X)
  • Apple tablet device (such as the iPhone Pro)

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Browser testing passed.
  • Changelog updated.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the [email protected] mailing list!

@github-actions github-actions bot added work in progress POC / Not ready for review styles An issue or PR pertaining only to CSS/Sass labels Jun 30, 2021
@netlify
Copy link

netlify bot commented Jun 30, 2021

✔️ Deploy Preview for patternfly-elements ready!

🔨 Explore the source changes: 88be71f

🔍 Inspect the deploy log: https://app.netlify.com/sites/patternfly-elements/deploys/60de0198e3c2350007557869

😎 Browse the preview: https://deploy-preview-1697--patternfly-elements.netlify.app

@castastrophe castastrophe linked an issue Jun 30, 2021 that may be closed by this pull request
@castastrophe castastrophe added fix priority: low Severity level: 3 labels Jun 30, 2021
@github-actions github-actions bot added the AT passed Automated testing has passed label Jul 28, 2021
@bennypowers bennypowers deleted the fix-band-regional-overflow branch June 25, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed fix priority: low Severity level: 3 styles An issue or PR pertaining only to CSS/Sass work in progress POC / Not ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] pfe-band | max-width: auto which isn't valid

2 participants