Skip to content

fix(datastore): handle not found error for S3 HeadObject #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025
Merged

fix(datastore): handle not found error for S3 HeadObject #588

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17d9bfe
fix(datastore): handle not found error for S3 HeadObject
corrieriluca Apr 29, 2025
174927b
Merge branch 'main' into fix/not-found-s3-head-object
AlanLonguet May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions internal/datastore/storage/s3/s3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
storage "github.com/aws/aws-sdk-go-v2/service/s3"
"github.com/aws/aws-sdk-go-v2/service/s3/types"
"github.com/aws/aws-sdk-go/aws"
"github.com/aws/smithy-go"
"github.com/padok-team/burrito/internal/burrito/config"
storageerrors "github.com/padok-team/burrito/internal/datastore/storage/error"
)
Expand Down Expand Up @@ -72,26 +73,36 @@ func (a *S3) Check(key string) ([]byte, error) {

result, err := a.Client.HeadObject(context.TODO(), input)
if err != nil {
var noKey *types.NoSuchKey
if errors.As(err, &noKey) {
return make([]byte, 0), &storageerrors.StorageError{
Err: err,
Nil: true,
var apiError smithy.APIError
if errors.As(err, &apiError) {
switch apiError.(type) {
case *types.NotFound:
return make([]byte, 0), &storageerrors.StorageError{
Err: err,
Nil: true,
}
default:
break
}
}
return make([]byte, 0), err
}

// S3 returns a checksum only if the object was uploaded with one
if result.ChecksumSHA256 == nil {
return make([]byte, 0), nil
}

return []byte(*result.ChecksumSHA256), nil
}

func (a *S3) Set(key string, data []byte, ttl int) error {
input := &storage.PutObjectInput{
Bucket: &a.Config.Bucket,
Key: &key,
Body: bytes.NewReader(data),
Bucket: &a.Config.Bucket,
Key: &key,
Body: bytes.NewReader(data),
ChecksumAlgorithm: types.ChecksumAlgorithmSha256,
}

_, err := a.Client.PutObject(context.TODO(), input)
if err != nil {
return err
Expand Down