Skip to content

fix(datastore): handle not found error for S3 HeadObject #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025

Conversation

corrieriluca
Copy link
Member

The Check operation on the datastore was not working as expected when using S3 (tested with MinIO):

  • NotFound error was not correctly checked
  • A nil-pointer dereference exception was raised on the checksum because S3 does not set a checksum by default in its responses.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in burrito May 9, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 44.93%. Comparing base (125b9b0) to head (174927b).

Files with missing lines Patch % Lines
internal/datastore/storage/s3/s3.go 0.00% 17 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
- Coverage   44.98%   44.93%   -0.05%     
==========================================
  Files          79       79              
  Lines        5753     5759       +6     
==========================================
  Hits         2588     2588              
- Misses       2950     2956       +6     
  Partials      215      215              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@corrieriluca corrieriluca requested a review from LucasMrqes May 12, 2025 08:33
@corrieriluca corrieriluca moved this from 📋 Backlog to 👀 In review in burrito May 16, 2025
@LucasMrqes LucasMrqes force-pushed the fix/not-found-s3-head-object branch from efe6757 to 17d9bfe Compare May 16, 2025 14:22
@corrieriluca corrieriluca merged commit 765acea into main May 21, 2025
7 checks passed
@corrieriluca corrieriluca deleted the fix/not-found-s3-head-object branch May 21, 2025 09:52
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in burrito May 21, 2025
michael-todorovic added a commit to michael-todorovic/burrito that referenced this pull request May 27, 2025
Signed-off-by: Michael Todorovic <[email protected]>
michael-todorovic added a commit to michael-todorovic/burrito that referenced this pull request May 27, 2025
Signed-off-by: Michael Todorovic <[email protected]>
michael-todorovic added a commit to michael-todorovic/burrito that referenced this pull request May 27, 2025
Signed-off-by: Michael Todorovic <[email protected]>
michael-todorovic added a commit to michael-todorovic/burrito that referenced this pull request May 27, 2025
Signed-off-by: Michael Todorovic <[email protected]>
corrieriluca pushed a commit to michael-todorovic/burrito that referenced this pull request Jun 2, 2025
Signed-off-by: Michael Todorovic <[email protected]>
corrieriluca pushed a commit that referenced this pull request Jun 2, 2025
* fix(s3): check for ChecksumAlgorithmSha256 support

Signed-off-by: Michael Todorovic <[email protected]>

* fix: revert partially #588

Signed-off-by: Michael Todorovic <[email protected]>

---------

Signed-off-by: Michael Todorovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants