Fix/reorganize to/fromJSON code #5403
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ChrisDodd
commented
Oct 21, 2025
ChrisDodd
commented
- fix UnparsedConstant handling
- clean up corner cases of fromJSON
asl
reviewed
Oct 21, 2025
| std::enable_if_t<has_fromJSON<T>::value && !std::is_base_of_v<IR::INode, T> && | ||
| std::is_pointer_v<decltype(T::fromJSON(std::declval<JSONLoader &>()))>> | ||
| unpack_json(T &v) { | ||
| v = *(T::fromJSON(*this)); |
There was a problem hiding this comment.
Does it make sense to force move semantics here?
There was a problem hiding this comment.
You already get move semantics, as T::fromJSON returns a type T xvalue. That's actually how calling std::move forces move semantics -- std::move is just a function that returns a type T xvalue. There's nothing special about it.
There was a problem hiding this comment.
I was under impression that T::fromJSON returns a pointer – T*, no? So v = *(T::fromJSON(*this)) would incur a copy.
There was a problem hiding this comment.
It can either return a T or a T *. If it is a T * then it might not be safe to move?
fruffy
added
the
core
ChrisDodd
force-pushed
the
cdpdd-json-fixes
branch
3 times, most recently
from
4d123ef to
46fb2fd
Compare
- fix UnparsedConstant handling - clean up corner cases of fromJSON Signed-off-by: Chris Dodd <[email protected]>
ChrisDodd
force-pushed
the
cdpdd-json-fixes
branch
from
46fb2fd to
a2f6523
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.