Make the Tofino spec files independent of the generated IR. #5063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
force-pushed
the
fruffy/tofino_specs
branch
2 times, most recently
from
e1813de to
8aae242
Compare
fruffy
commented
Dec 13, 2024
asl
reviewed
Dec 13, 2024
fruffy
force-pushed
the
fruffy/tofino_specs
branch
3 times, most recently
from
71eb3a4 to
4449f61
Compare
fruffy
force-pushed
the
fruffy/tofino_specs
branch
5 times, most recently
from
12d9c9e to
4698dac
Compare
fruffy
force-pushed
the
fruffy/tofino_specs
branch
10 times, most recently
from
baeabce to
d38fe51
Compare
fruffy
force-pushed
the
fruffy/tofino_specs
branch
from
d38fe51 to
1afef2f
Compare
fruffy
force-pushed
the
fruffy/tofino_specs
branch
3 times, most recently
from
5424d75 to
f064ca7
Compare
fruffy
force-pushed
the
fruffy/tofino_specs
branch
from
f064ca7 to
9ec0eb0
Compare
fruffy
force-pushed
the
fruffy/tofino_specs
branch
from
9ec0eb0 to
404bd5a
Compare
Signed-off-by: fruffy <[email protected]>
Signed-off-by: fruffy <[email protected]>
Signed-off-by: fruffy <[email protected]>
fruffy
force-pushed
the
fruffy/tofino_specs
branch
from
404bd5a to
876b954
Compare
|
This looks fine, but I'm a bit worried about our lack of tofino testing in CI. A hard-to-spot typo in any one of the 100s of small moves/edits here could break things, and we have no way of noticing. At the very least, we should run the https://github.com/p4lang/open-p4studio test suite with all of these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to depend on these files without pulling in the entire compiler. The advantages of this separation is a mid end that does not depend on the Tofino back end and the ability of other tools (primarily P4Testgen) to link into certain Tofino files.