Skip to content

fix kueue service monitor with correct port to scrape metrics #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

fix kueue service monitor with correct port to scrape metrics #852

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
739023d
correct the port reference for the service monitor
mukrishn Oct 22, 2025
0472290
add a label to metrics-services
mukrishn Oct 22, 2025
cb2e84b
update the label to pick the right service
mukrishn Oct 22, 2025
16fc382
updating the port name
mukrishn Oct 23, 2025
3fc9b59
revoked the port name from the servicemonitor spec
mukrishn Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bindata/assets/kueue-operator/controller-manager-metrics-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ metadata:
app.kubernetes.io/managed-by: kustomize
app.kubernetes.io/name: kueue
control-plane: controller-manager
app: metrics-service
name: kueue-controller-manager-metrics-service
namespace: openshift-kueue-operator
spec:
Expand Down
4 changes: 2 additions & 2 deletions pkg/operator/target_config_reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1398,14 +1398,14 @@ func (c *TargetConfigReconciler) manageServiceMonitor(ctx context.Context, kueue
Spec: monitoringv1.ServiceMonitorSpec{
Selector: metav1.LabelSelector{
MatchLabels: map[string]string{
"control-plane": "controller-manager",
"app": "metrics-service",
},
},
Endpoints: []monitoringv1.Endpoint{
{
Interval: "30s",
Path: "/metrics",
Port: "metrics", // Name of the port you want to monitor
Port: "https", // Name of the port you want to monitor
Copy link
Contributor

@kannon92 kannon92 Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may break our network policies actually.

@tkashem made this change as part of ec72771

Copy link
Member Author

@mukrishn mukrishn Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, actually that PR had updated the port name in both places, later it was revoked partially during this change and I guess that introduced this problem.
I will update the fix.

Scheme: "https",
BearerTokenFile: "/var/run/secrets/kubernetes.io/serviceaccount/token",
TLSConfig: &monitoringv1.TLSConfig{
Expand Down