fix kueue service monitor with correct port to scrape metrics #852
Conversation
current label `control-plane: controller-manager` selects more than 1 service from the namespace, causes multiple invalid entries in to prometheus target
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mukrishn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you for the fix! /hold I'm going to verify that I can reproduce this and that this actually fixes it. |
openshift-ci
bot
added
the
do-not-merge/hold
| Interval: "30s", | ||
| Path: "/metrics", | ||
| Port: "metrics", // Name of the port you want to monitor | ||
| Port: "https", // Name of the port you want to monitor |
There was a problem hiding this comment.
I see, actually that PR had updated the port name in both places, later it was revoked partially during this change and I guess that introduced this problem.
I will update the fix.
updating this name as suggested in the comment, this is required for the network policy rules.
|
@mukrishn: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
This does look like it fixes the metrics issue. |
|
We need to fix this upstream and downstream. Opened 2 PRs: kubernetes-sigs/kueue#7371 The kueue-operator PR won't work until upstream merges, and get's backported to 0.14. |
|
Thank you for the contribution. Fixed via #856 /close |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@rphillips: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
The metrics-service added during the installation is configured with an incorrect port reference, causing Prometheus to fail in scraping metrics from the Kueue endpoint - Updated the right port name, from this spec
Also the service selector label
control-plane: controller-managerselects more than 1 service from the namespace, causes multiple invalid entries in to prometheus target config - Added a new label and updated the selector.Fixes: RHOAIENG-36974