Skip to content

Conversation

@richardsonnick
Copy link

Adds feature gate for TLS curves configuration in API config.

Enhancement PR: openshift/enhancements#1894
Implementation PR: #2583

@richardsonnick richardsonnick changed the title Curves feature gate TLS curves configuration feature gate Nov 20, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 20, 2025

Walkthrough

Adds a new public feature gate FeatureGateTLSCurvesConfiguration to the allFeatureGates initializer in features/features.go, declared with metadata for TLS curves configuration (name, Jira component, contact, product scope, enhancement PR, enablement level, must-register flag).

Changes

Cohort / File(s) Summary
Feature gate addition
features/features.go
Adds FeatureGateTLSCurvesConfiguration to the allFeatureGates var block as a new public feature gate with: name "TLSCurvesConfiguration", ReportProblemsToJiraComponent set to "Networking", ContactPerson set to "davidesalerno", ProductScope ocpSpecific, EnhancementPR "https://github.com/openshift/enhancements/pull/1894", EnableIn configv1.DevPreviewNoUpgrade, and MustRegister enabled.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify the enhancement PR link is correct and relevant.
  • Confirm Jira component (Networking) and contact (davidesalerno) are appropriate.
  • Validate EnableIn level configv1.DevPreviewNoUpgrade and MustRegister usage.
  • Ensure declaration style and metadata match existing feature gate patterns.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between bd8af6d and 524928d.

📒 Files selected for processing (1)
  • features/features.go (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • features/features.go
🔇 Additional comments (1)
features/features.go (1)

943-949: Enhancement PR verified and code structure is correct.

The enhancement PR #1894 ("Add enhancement spec for api tls curves") is accessible and actively reviewed by multiple stakeholders. The code follows the established pattern correctly, and the Jira component assignment to "Networking" is properly configured. No issues identified.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

Hello @richardsonnick! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci-robot
Copy link

Pipeline controller notification
This repository is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 20, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mustRegister()

FeatureGateTLSCurvesConfiguration = newFeatureGate("TLSCurvesConfiguration").
reportProblemsToJiraComponent("kube-apiserver").
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should problems be reported to this component?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, I'm asking because I don't see any stakeholders from the team responsible for this component represented in the enhancement proposal as reviewers or having signed off on being on the hook for bugs and issues related to this feature.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @everettraven,
Sorry for the confusion, I'm working with @davidesalerno to add supporting docs for the new feature introduced here: #2583

We decided Networking was the best component.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2025

@richardsonnick: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 524928d link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants