OCPBUGS-33727: Fix Gateway API Feature Gate

[candita]

Update the feature gate framework to reflect that Gateway API is not yet a TechPreview feature. It is only a DevPreview feature.

Gateway API was added as a DevPreviewNoUpgrade feature before recent changes to the FeatureGate framework, and has not progressed to TechPreviewNoUpgrade. When the FeatureGate framework changed, Gateway API was mistakenly listed as a TechPreviewNoUpgrade feature.

For 4.16 we are adding TechPreview testing to the cluster-ingress-operator for other features, and we do not want to test Gateway API as a tech preview feature. In fact, it has its own separate test.

• features/features.go is the only edited file. All other files were generated.

[openshift-ci-robot]

@candita: This pull request references Jira Issue OCPBUGS-33727, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Update the feature gate framework to reflect that Gateway API is not yet a TechPreview feature. It is only a DevPreview feature.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @candita! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[candita]

/jira refresh

[openshift-ci-robot]

@candita: This pull request references Jira Issue OCPBUGS-33727, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@candita: This pull request references Jira Issue OCPBUGS-33727, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

Update the feature gate framework to reflect that Gateway API is not yet a TechPreview feature. It is only a DevPreview feature.

Gateway API was added as a DevPreviewNoUpgrade feature before recent changes to the FeatureGate framework, and has not progressed to TechPreviewNoUpgrade. When the FeatureGate framework changed, Gateway API was mistakenly listed as a TechPreviewNoUpgrade feature.

For 4.16 we are adding TechPreview testing to the cluster-ingress-operator for other features, and we do not want to test Gateway API as a tech preview feature. In fact, it has its own separate test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[candita]

Quite a few cluster creation errors in e2e-aws-ovn-hypershift. For example:

=== NAME TestUpgradeControlPlane/ValidateHostedCluster
util.go:340:
failed waiting for hostedcluster image rollout: status.version.history[0].state is "Partial", but we want "Completed"
Unexpected error:
<wait.errInterrupted>:
timed out waiting for the condition
{
cause: <*errors.errorString | 0xc00080e900>{
s: "timed out waiting for the condition",
},
}
occurred

/test e2e-aws-ovn-hypershift

[gcs278]

From a NE perspective, this seems reasonable, it shouldn't be in the TechPreviewNoUpgrade feature set.
/lgtm

[JoelSpeed]

/lgtm
/label acknowledge-critical-fixes-only

As far as I'm aware, this shouldn't break anything. There are no API changes behind the gate so no operator should start crashing on us. I think it's important we have the gates in the right order prior to release, so, lets merge this.

[JoelSpeed]

/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita, gcs278, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD a20192e and 2 for PR HEAD 45d9c7e in total

[gcs278]

XREF: This corrects #1452

[openshift-ci]

@candita: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@candita: Jira Issue OCPBUGS-33727: All pull requests linked via external trackers have merged:

• openshift/api#1894

Jira Issue OCPBUGS-33727 has been moved to the MODIFIED state.

In response to this:

Update the feature gate framework to reflect that Gateway API is not yet a TechPreview feature. It is only a DevPreview feature.

Gateway API was added as a DevPreviewNoUpgrade feature before recent changes to the FeatureGate framework, and has not progressed to TechPreviewNoUpgrade. When the FeatureGate framework changed, Gateway API was mistakenly listed as a TechPreviewNoUpgrade feature.

For 4.16 we are adding TechPreview testing to the cluster-ingress-operator for other features, and we do not want to test Gateway API as a tech preview feature. In fact, it has its own separate test.

• features/features.go is the only edited file. All other files were generated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.16.0-202405161711.p0.g1dea023.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-05-17-180525