Skip to content

Fix context leak on jetty #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2021
Merged

Fix context leak on jetty #2920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .../opentelemetry/javaagent/instrumentation/api/concurrent/ExecutorInstrumentationUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,13 @@ protected Boolean computeValue(Class<?> taskClass) {
return false;
}

// HttpConnection implements Runnable. When async request is completed HttpConnection
// may be sent to process next request while context from previous request hasn't been
// cleared yet.
if (taskClass.getName().equals("org.eclipse.jetty.server.HttpConnection")) {
return false;
}

Class<?> enclosingClass = taskClass.getEnclosingClass();
if (enclosingClass != null) {
// Avoid context leak on jetty. Runnable submitted from SelectChannelEndPoint is used to
Expand Down