Skip to content

Fix context leak on jetty #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2021
Merged

Fix context leak on jetty #2920

merged 1 commit into from
May 6, 2021

Conversation

@laurit
Copy link
Contributor

@laurit laurit commented May 6, 2021

Resolves #2915

trask
trask approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ one more context leak down!

iNikem
iNikem approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@iNikem iNikem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laurit you are a magician :D

@trask trask merged commit 9637d29 into open-telemetry:main May 6, 2021
@laurit laurit deleted the jetty-context-leak2 branch August 24, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trask trask trask approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@jkwatson jkwatson Awaiting requested review from jkwatson

@mateuszrzeszutek mateuszrzeszutek Awaiting requested review from mateuszrzeszutek

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

+1 more reviewer

@iNikem iNikem iNikem approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nightly build

3 participants

@laurit @trask @iNikem