Skip to content

Clarify nature of Codes values w.r.t. OTLP #3386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 28, 2022
Merged

Clarify nature of Codes values w.r.t. OTLP #3386

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fa01310
Clarify nature of Codes values w.r.t. OTLP
cartermp Oct 21, 2022
6b035d7
Update codes/codes.go
cartermp Oct 21, 2022
5dffecf
Merge branch 'main' into cartermp/codes-clarification
cartermp Oct 21, 2022
12501c5
go eff em tee dash ehs
cartermp Oct 21, 2022
a9e1984
Merge branch 'main' into cartermp/codes-clarification
MrAlias Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions codes/codes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,20 @@ import (
const (
// Unset is the default status code.
Unset Code = 0

// Error indicates the operation contains an error.
//
// NOTE: The error code in OTLP is 2.
// The value of this enum is only relevant to the internals
// of the Go SDK.
Error Code = 1

// Ok indicates operation has been validated by an Application developers
// or Operator to have completed successfully, or contain no error.
//
// NOTE: The Ok code in OTLP is 1.
// The value of this enum is only relevant to the internals
// of the Go SDK.
Ok Code = 2

maxCode = 3
Expand Down