Clarify nature of Codes values w.r.t. OTLP #3386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2098
We had a team using otel-go see the integer values of span status codes in honeycomb, then went to look them up on pkg.go.dev. However, they got very confused because the values of Ok and Error are flipped w.r.t. OTLP. I think calling this out in the comments, which also enables seeing the note in editor tools, can reduce future confusion on this topic.
I think that this could also go in the docs, but not exclusively there because people will still use editor tooling and pkg.go.dev to look things up.