- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.2k
sdk/trace: removing ApplyConfig and Config #1693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Codecov Report
 @@          Coverage Diff          @@
##            main   #1693   +/-   ##
=====================================
  Coverage   77.8%   77.9%           
=====================================
  Files        130     131    +1     
  Lines       7013    6997   -16     
=====================================
- Hits        5463    5451   -12     
+ Misses      1299    1296    -3     
+ Partials     251     250    -1     
 | 
433342a    to
    e38c0fd      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd like to see a different solution to getting TracerProviderOptions from the exporter pipeline convenience methods to the TracerProvider initialization before landing this.
| @ijsong sorry about the churn on this, there were several other issues working in the same area though I think we've made it through most of them. @open-telemetry/go-approvers can we get another approval on this so we can land it? | 
| @Aneurysm9 No problem, I fixed some issues after merging main branch, and renamed field name  | 
de816d9    to
    50af6b7      
    Compare
  
    This patch removes `ApplyConfig` method and `Config` struct from `go.opentelemetry.io/otel/sdk/trace` package. To ensure valid config for TracerProvider, it adds `ensureValidTracerProviderConfig` private function. Jaeger and Zipkin have been used the `Config` directly across package boundaries. Since `Config` is removed, they can't use it. This change, thus, replaces `WithSDK` with `WithSDKOptions`. Resolves open-telemetry#1636, open-telemetry#1705.
This patch removes
ApplyConfigmethod andConfigstruct fromgo.opentelemetry.io/otel/sdk/tracepackage. To ensure valid config for TracerProvider, it addsensureValidTracerProviderConfigprivate function.Jaeger and Zipkin have been used the
Configdirectly across package boundaries. SinceConfigis removed, they can't use it. This change, thus, replacesWithSDKwithWithSDKOptions.Resolves #1636, #1705.